-
Notifications
You must be signed in to change notification settings - Fork 8
remove old server #536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove old server #536
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the old server implementation and consolidates the new server implementation to replace it. The purpose is to clean up the codebase by eliminating the legacy server and making the new Effect-based server the primary implementation.
- Complete removal of old Express/WebSocket-based server with all handlers and utilities
- Consolidation of new Effect-based server to become the main server implementation
- Configuration updates including dependency changes and build target modifications
Reviewed Changes
Copilot reviewed 83 out of 116 changed files in this pull request and generated 3 comments.
Show a summary per file
File | Description |
---|---|
apps/server/tsconfig.json | Updated trailing comma for consistency |
apps/server/tsup.config.ts | Added Node.js 22 target and build configuration options |
apps/server/src/index.ts | Replaced with new Effect-based server implementation |
apps/server/package.json | Updated dependencies and scripts for new server architecture |
Multiple old server files | Complete removal of legacy Express-based server handlers and utilities |
Multiple server-new files | Removed as functionality was moved to main server |
Build configuration files | Updated references from server-new to server |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
apps/server/src/index.ts
Outdated
import * as Config from './config/honeycomb.ts'; | ||
import { server } from './server.ts'; |
Copilot
AI
Sep 14, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[nitpick] The .ts extensions in import statements are unnecessary when using TypeScript with bundlers like tsup. Consider removing them for cleaner imports: './config/honeycomb'
and './server'
.
import * as Config from './config/honeycomb.ts'; | |
import { server } from './server.ts'; | |
import * as Config from './config/honeycomb'; | |
import { server } from './server'; |
Copilot uses AI. Check for mistakes.
No description provided.