Skip to content

Conversation

nikgraf
Copy link
Collaborator

@nikgraf nikgraf commented Sep 14, 2025

No description provided.

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the old server implementation and consolidates the new server implementation to replace it. The purpose is to clean up the codebase by eliminating the legacy server and making the new Effect-based server the primary implementation.

  • Complete removal of old Express/WebSocket-based server with all handlers and utilities
  • Consolidation of new Effect-based server to become the main server implementation
  • Configuration updates including dependency changes and build target modifications

Reviewed Changes

Copilot reviewed 83 out of 116 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
apps/server/tsconfig.json Updated trailing comma for consistency
apps/server/tsup.config.ts Added Node.js 22 target and build configuration options
apps/server/src/index.ts Replaced with new Effect-based server implementation
apps/server/package.json Updated dependencies and scripts for new server architecture
Multiple old server files Complete removal of legacy Express-based server handlers and utilities
Multiple server-new files Removed as functionality was moved to main server
Build configuration files Updated references from server-new to server
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment on lines 5 to 6
import * as Config from './config/honeycomb.ts';
import { server } from './server.ts';
Copy link

Copilot AI Sep 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[nitpick] The .ts extensions in import statements are unnecessary when using TypeScript with bundlers like tsup. Consider removing them for cleaner imports: './config/honeycomb' and './server'.

Suggested change
import * as Config from './config/honeycomb.ts';
import { server } from './server.ts';
import * as Config from './config/honeycomb';
import { server } from './server';

Copilot uses AI. Check for mistakes.

@nikgraf nikgraf merged commit bd6b5a6 into main Sep 14, 2025
6 checks passed
@nikgraf nikgraf deleted the ng/remove-old-server branch September 14, 2025 18:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant