Skip to content

fix: remove escrow adapter check #483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2024
Merged

fix: remove escrow adapter check #483

merged 2 commits into from
Nov 13, 2024

Conversation

gusinacio
Copy link
Contributor

Fixes #481

@gusinacio gusinacio requested a review from mangas November 11, 2024 17:53
@gusinacio gusinacio force-pushed the gustavo/tap-297-remove-any-checks-in-escrowadapter branch from ac38b6a to 97b29ea Compare November 11, 2024 17:54
@coveralls
Copy link

coveralls commented Nov 11, 2024 •
edited
Loading

Pull Request Test Coverage Report for Build 11809981265

Details

  • 8 of 11 (72.73%) changed or added relevant lines in 1 file are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.3%) to 72.589%
Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/tap-agent/src/tap/context/escrow.rs 8 11 72.73%
Files with Coverage Reduction New Missed Lines %
crates/tap-agent/src/tap/context/escrow.rs 1 55.0%
Totals Coverage Status
Change from base Build 11809937770: -0.3%
Covered Lines: 5630
Relevant Lines: 7756
💛 - Coveralls

@gusinacio gusinacio force-pushed the gustavo/tap-297-remove-any-checks-in-escrowadapter branch from 5df3280 to 31305ad Compare November 13, 2024 03:17
@gusinacio
fix: remove escrow adapter check
9e7f875 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio
test: turn receipts into invalid
3878e9c 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio force-pushed the gustavo/tap-297-remove-any-checks-in-escrowadapter branch from 31305ad to 3878e9c Compare November 13, 2024 03:18
@gusinacio gusinacio merged commit 1faa61e into main Nov 13, 2024
7 checks passed
@gusinacio gusinacio deleted the gustavo/tap-297-remove-any-checks-in-escrowadapter branch November 13, 2024 16:58
@github-actions github-actions bot mentioned this pull request Nov 13, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@mangas mangas mangas approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Remove any checks in EscrowAdapter
3 participants
@gusinacio @coveralls @mangas