Skip to content

refactor: use notify wrapper for rav trigger #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 14, 2024
Merged

refactor: use notify wrapper for rav trigger #135

merged 1 commit into from
Mar 14, 2024

Conversation

gusinacio
Copy link
Contributor

No description provided.

@gusinacio
refactor: use notify wrapper for rav trigger
57fc3a9 
Signed-off-by: Gustavo Inacio <gustavo@semiotic.ai>
@gusinacio gusinacio requested a review from aasseman March 14, 2024 19:21
@coveralls
Copy link

Pull Request Test Coverage Report for Build 8286434937

Details

  • 24 of 28 (85.71%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.04%) to 63.826%
Changes Missing Coverage Covered Lines Changed/Added Lines %
tap-agent/src/tap/sender_account.rs 24 28 85.71%
Totals Coverage Status
Change from base Build 8271245724: 0.04%
Covered Lines: 2869
Relevant Lines: 4495
💛 - Coveralls

@aasseman aasseman merged commit e3bebc2 into main Mar 14, 2024
@aasseman aasseman deleted the gusinacio/notify_wrapper branch March 14, 2024 19:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@aasseman aasseman aasseman approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@gusinacio @coveralls @aasseman