Skip to content

Add xml docs #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 20, 2021
Merged

Add xml docs #108

merged 2 commits into from
Jan 20, 2021

Conversation

sungam3r
Copy link
Member

No description provided.

@sungam3r sungam3r requested a review from Shane32 January 20, 2021 21:49
sungam3r
sungam3r commented Jan 20, 2021
View reviewed changes
@sungam3r sungam3r added the documentation An issue or pull request regarding documentation improvements label Jan 20, 2021
Shane32
Shane32 approved these changes Jan 20, 2021
View reviewed changes
Copy link
Member

@Shane32 Shane32 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good start! Any idea how many more warnings are left?

@sungam3r
Copy link
Member Author

I'm not a native speaker. It's better to double-check what I wrote in the comments.

@sungam3r
Copy link
Member Author

Any idea how many more warnings are left?

168

@Shane32
Copy link
Member

Shane32 commented Jan 20, 2021

I read all the comments. They seem fine.

@sungam3r sungam3r merged commit 9c581b6 into develop Jan 20, 2021
@sungam3r sungam3r deleted the docs branch January 20, 2021 22:29
@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Shane32 Shane32 Shane32 approved these changes

Assignees
No one assigned
Labels
documentation An issue or pull request regarding documentation improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sungam3r @Shane32