Skip to content

Remove extension methods #112

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jan 22, 2021
Merged

Remove extension methods #112

merged 7 commits into from
Jan 22, 2021

Conversation

Shane32
Copy link
Member

@Shane32 Shane32 commented Jan 22, 2021

Fixes #111

@Shane32 Shane32 requested a review from sungam3r January 22, 2021 21:27
@Shane32 Shane32 self-assigned this Jan 22, 2021
@github-actions github-actions bot added performance test Pull request that adds new or changes existing tests labels Jan 22, 2021
sungam3r
sungam3r reviewed Jan 22, 2021
View reviewed changes
sungam3r
sungam3r reviewed Jan 22, 2021
View reviewed changes
Shane32 and others added 2 commits January 22, 2021 16:30
@Shane32 @sungam3r
Update src/GraphQLParser.Tests/Extensions.cs
11f4b56 
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@Shane32 @sungam3r
Update src/GraphQLParser.Tests/Extensions.cs
3aea322 
Co-authored-by: Ivan Maximov <sungam3r@yandex.ru>
@sungam3r
Copy link
Member

OK. Please change also readme.

@github-actions github-actions bot added the documentation An issue or pull request regarding documentation improvements label Jan 22, 2021
@Shane32 Shane32 merged commit f1d7caa into develop Jan 22, 2021
@Shane32 Shane32 deleted the remove_extensions branch January 22, 2021 21:35
@sungam3r
Copy link
Member

Now see if #111 closes automatically.

@sungam3r
Copy link
Member

Nope

@Shane32
Copy link
Member Author

Shane32 commented Jan 22, 2021

Yeah, weird.

@sungam3r
Copy link
Member

https://github.blog/2013-01-22-closing-issues-via-commit-messages/

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sungam3r sungam3r sungam3r approved these changes

Assignees

@Shane32 Shane32

Labels
documentation An issue or pull request regarding documentation improvements performance test Pull request that adds new or changes existing tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Shane32 @sungam3r