Skip to content

Simplify assembly signing #265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 10, 2022
Merged

Simplify assembly signing #265

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
81fe750
Simplify assembly signing
sungam3r Aug 10, 2022
21c2888
format
sungam3r Aug 10, 2022
70b1a84
fixes
sungam3r Aug 10, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,14 +23,8 @@
<Nullable>enable</Nullable>
<ImplicitUsings>enable</ImplicitUsings>
<PackageReadmeFile Condition="'$(IsPackable)' == 'true'">README.md</PackageReadmeFile>

<!--
Strong name signing of netstandard assemblies for better cross-runtime compatibility

Ref: https://docs.microsoft.com/en-us/dotnet/core/compatibility/core-libraries/6.0/strong-name-signing-exceptions#recommended-action
-->
<SignAssembly>true</SignAssembly>
<CustomBeforeMicrosoftCommonTargets>$(MSBuildThisFileDirectory)_SignAssembly.targets</CustomBeforeMicrosoftCommonTargets>
<AssemblyOriginatorKeyFile>..\graphql.snk</AssemblyOriginatorKeyFile>
</PropertyGroup>

<ItemGroup Condition="'$(IsPackable)' == 'true'">
Expand Down
2 changes: 0 additions & 2 deletions src/GraphQLParser.sln
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,9 +18,7 @@ Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution
graphql.snk = graphql.snk
..\LICENSE.md = ..\LICENSE.md
..\assets\logo.64x64.png = ..\assets\logo.64x64.png
public.snk = public.snk
..\README.md = ..\README.md
_SignAssembly.targets = _SignAssembly.targets
EndProjectSection
EndProject
Project("{9A19103F-16F7-4668-BE54-9A1E7A4F7556}") = "GraphQLParser.ApiTests", "GraphQLParser.ApiTests\GraphQLParser.ApiTests.csproj", "{6F01D881-DEA2-4259-977B-FF56DD366592}"
Expand Down
5 changes: 1 addition & 4 deletions src/GraphQLParser/AST/GraphQLName.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,12 +36,9 @@ public string StringValue
{
get
{
if (_string == null)
{
_string = Value.Length == 0
_string ??= Value.Length == 0
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new versions of NET SDK is more and more smart

? string.Empty
: (string)Value;
}

return _string;
}
Expand Down
2 changes: 1 addition & 1 deletion src/GraphQLParser/GraphQLParser.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
<Project Sdk="Microsoft.NET.Sdk">
<Project Sdk="Microsoft.NET.Sdk">

<PropertyGroup>
<Description>Library containing lexer and parser for GraphQL syntax</Description>
Expand Down
32 changes: 0 additions & 32 deletions src/_SignAssembly.targets
View file
Open in desktop

This file was deleted.

Binary file removed src/public.snk
View file
Open in desktop
Binary file not shown.