Skip to content

Fix printing description on schema #310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 20, 2023
Merged

Fix printing description on schema #310

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
<Project>

<PropertyGroup>
<VersionPrefix>8.0.0-preview</VersionPrefix>
<VersionPrefix>9.0.1-preview</VersionPrefix>
<LangVersion>latest</LangVersion>
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<NoWarn>$(NoWarn);CA1707</NoWarn>
Expand Down
13 changes: 13 additions & 0 deletions src/GraphQLParser.Tests/Visitors/SDLPrinterFromParsedTextTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -641,6 +641,19 @@ query q(
$a: Int) {
x
}
""")]
[InlineData(49,
"""
"description"
schema {
query: Query
}
""",
"""
"description"
schema {
query: Query
}
""")]
public async Task SDLPrinter_Should_Print_Document(
int number,
Expand Down
2 changes: 1 addition & 1 deletion src/GraphQLParser/Visitors/SDLPrinter.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -607,7 +607,7 @@ protected override async ValueTask VisitSchemaDefinitionAsync(GraphQLSchemaDefin
{
await VisitAsync(schemaDefinition.Comments, context).ConfigureAwait(false);
await VisitAsync(schemaDefinition.Description, context).ConfigureAwait(false);
await context.WriteAsync("schema").ConfigureAwait(false);
await VisitAsync(LiteralNode.Wrap("schema"), context).ConfigureAwait(false);
await VisitAsync(schemaDefinition.Directives, context).ConfigureAwait(false);

//bool freshLine = schemaDefinition.Comments != null && Options.PrintComments; always false
Expand Down