Skip to content

Conversation

sungam3r
Copy link
Member

No description provided.

@sungam3r sungam3r requested a review from Shane32 April 21, 2023 16:16
@sungam3r sungam3r self-assigned this Apr 21, 2023
@github-actions github-actions bot added CI CI configuration issue or pull request test Pull request that adds new or changes existing tests labels Apr 21, 2023
@sungam3r
Copy link
Member Author

v8 will be a long-lived branch like v5 from core repo

@sungam3r sungam3r merged commit 1e0455d into v8 Apr 21, 2023
@sungam3r sungam3r deleted the ctors-back branch April 21, 2023 16:20
@Shane32
Copy link
Member

Shane32 commented Apr 21, 2023

It's so nice being able to easily push to any version on an as-needed basis. Even now, if you delete the v8 branch, it's already tagged, and can be brought back to an actual branch with a few clicks.

@sungam3r
Copy link
Member Author

Yep. And I want to note that with MinVer such behavior is preserved.

@Shane32
Copy link
Member

Shane32 commented Apr 21, 2023

Yep. And I want to note that with MinVer such behavior is preserved.

But it just isn't necessary. Dependencies are security vulnerabilities. They are dependabot nuisances. Why add another one? So we don't have to change one line of code every few months (when we are already adding a new feature)? If it's so much trouble, just set it to a high version number and leave it alone, like I've said repeatedly.

Perhaps if GitHub Actions did not produce a run number, or we did not set the version when publishing, it would be great. That is not the case. Nearly everything is already automated.

In short, I believe it will cause more trouble than it solves.

@sungam3r
Copy link
Member Author

It is not necessary. It is just convenient, simple because fits into our workflow. Just give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI CI configuration issue or pull request test Pull request that adds new or changes existing tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants