Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Graphql v14 #11

Closed
wants to merge 1 commit into from
Closed

Conversation

baileylo
Copy link

@baileylo baileylo commented Apr 2, 2020

Changes the graphql version to 14. Fixes the BC break that resulted in a
compilation failure. I added a new method since tests were failing when
the original Util method was updated to check for GraphQLNamedInputType.

Changes the graphql version to 14. Fixes the BC break that resulted in a
compilation failure. I added a new method since tests were failing when
the original Util method was updated to check for GraphQLNamedInputType.
@baileylo
Copy link
Author

baileylo commented Apr 3, 2020

I felt it also might be possible to remove this new method entirely if isOneOfTheseTypes was changed to look like this. However, I feel that I'm probably missing some obvious use case.

protected boolean isOneOfTheseTypes(GraphQLInputType inputType, GraphQLScalarType... scalarTypes) {
        GraphQLInputType unwrappedType = Util.unwrapNonNull(inputType);
        for (GraphQLScalarType scalarType : scalarTypes) {
            if (scalarType.equals(unwrappedType)) {
                return true;
            }
        }
        return false;
    }

@brendamckenne
Copy link

 protected boolean isOneOfTheseTypes(GraphQLInputType inputType, GraphQLScalarType... scalarTypes) {
        GraphQLInputType unwrappedType = Util.unwrapNonNull(inputType);
        for (GraphQLScalarType scalarType : scalarTypes) {
            if (unwrappedType.getName().equals(scalarType.getName())) {
                return true;
            }
        }
        return false;
    }

has this code been fixed? it is creating issue with @notblank validation...
And is it merged into master? How can we get updated code?

@aoudiamoncef
Copy link
Contributor

Hi @bbakerman, @bbakerman,

I created this PR #14 to update the project dependencies. If it's not released soon, i'll publish my fork to maven central, because i really need this in my current project.

Thanks

@bbakerman
Copy link
Member

I have used #14 in favour for this fix

@bbakerman bbakerman closed this May 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants