Skip to content

Fix minor typos in MarkDown #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 5, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion content/documentation/master/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
6 changes: 3 additions & 3 deletions content/documentation/v10/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
Copy link
Contributor

@nutharsh nutharsh Oct 7, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@andimarek @jasper-vandemalle A random search across the web on computer processing reveals that parallelization is more commonly used term relative to parallelisation.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if you are guys are okay with opening another PR to fix it across.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nutharsh that would be great, yes

//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down Expand Up @@ -137,7 +137,7 @@ Here is how you might put this in place:

//
// this instrumentation implementation will dispatch all the dataloaders
// as each level fo the graphql query is executed and hence make batched objects
// as each level for the graphql query is executed and hence make batched objects
// available to the query and the associated DataFetchers
//
DataLoaderDispatcherInstrumentation dispatcherInstrumentation
Expand All @@ -155,7 +155,7 @@ Here is how you might put this in place:
{{< / highlight >}}

One thing to note is the above only works if you use `DataLoaderDispatcherInstrumentation` which makes sure `dataLoader.dispatch()`
is called. If this was not in place, then all the promises to data will never be dispatched ot the batch loader function
is called. If this was not in place, then all the promises to data will never be dispatched to the batch loader function
and hence nothing would ever resolve.

## Data Loader only works with AsyncExecutionStrategy
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v10/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v11/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v11/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v12/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v12/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v13/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v13/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v14/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v14/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v15/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v15/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -128,7 +128,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down
6 changes: 3 additions & 3 deletions content/documentation/v9/batching.md
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ Here is how you might put this in place:
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down Expand Up @@ -137,7 +137,7 @@ Here is how you might put this in place:

//
// this instrumentation implementation will dispatch all the dataloaders
// as each level fo the graphql query is executed and hence make batched objects
// as each level for the graphql query is executed and hence make batched objects
// available to the query and the associated DataFetchers
//
DataLoaderDispatcherInstrumentation dispatcherInstrumentation
Expand All @@ -155,7 +155,7 @@ Here is how you might put this in place:
{{< / highlight >}}

One thing to note is the above only works if you use `DataLoaderDispatcherInstrumentation` which makes sure `dataLoader.dispatch()`
is called. If this was not in place, then all the promises to data will never be dispatched ot the batch loader function
is called. If this was not in place, then all the promises to data will never be dispatched to the batch loader function
and hence nothing would ever resolve.

## Data Loader only works with AsyncExecutionStrategy
Expand Down
2 changes: 1 addition & 1 deletion content/documentation/v9/sdl-directives.md
Original file line number Diff line number Diff line change
Expand Up @@ -124,7 +124,7 @@ We now need to wire in the code that can handle any field with this ``@auth`` di
{{< / highlight >}}

This has modified the ``GraphQLFieldDefinition`` so that its original data fetcher will ONLY be called if the current authorisation context
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesnt
has the ``manager`` role. Exactly what mechanisms you use for authorisation is up to you. You could use Spring Security for example say, graphql-java doesn't
really care.

You would provide this authorisation checker into the execution "context" object of the graphql input so it can then be accessed later in the
Expand Down