Skip to content

Fix small typos on Batching page #98

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 3, 2022
Merged

Fix small typos on Batching page #98

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions documentation/batching.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ BatchLoader<String, Object> characterBatchLoader = new BatchLoader<String, Objec
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down Expand Up @@ -179,7 +179,7 @@ at [https://github.com/graphql-java/java-dataloader](https://github.com/graphql-
## Data Loader only works with AsyncExecutionStrategy

The only execution that works with DataLoader is `graphql.execution.AsyncExecutionStrategy`. This is because this execution strategy knows
then the most optimal time to dispatch() your load calls is. It does this by deeply tracking how many fields are outstanding and whether they
when the most optimal time to dispatch() your load calls is. It does this by deeply tracking how many fields are outstanding and whether they
are list values and so on.

Other execution strategies such as `ExecutorServiceExecutionStrategy` can't do this and hence if the data loader code detects
Expand Down
4 changes: 2 additions & 2 deletions versioned_docs/version-v18/batching.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ BatchLoader<String, Object> characterBatchLoader = new BatchLoader<String, Objec
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down Expand Up @@ -179,7 +179,7 @@ at [https://github.com/graphql-java/java-dataloader](https://github.com/graphql-
## Data Loader only works with AsyncExecutionStrategy

The only execution that works with DataLoader is `graphql.execution.AsyncExecutionStrategy`. This is because this execution strategy knows
then the most optimal time to dispatch() your load calls is. It does this by deeply tracking how many fields are outstanding and whether they
when the most optimal time to dispatch() your load calls is. It does this by deeply tracking how many fields are outstanding and whether they
are list values and so on.

Other execution strategies such as `ExecutorServiceExecutionStrategy` can't do this and hence if the data loader code detects
Expand Down
4 changes: 2 additions & 2 deletions versioned_docs/version-v19/batching.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ BatchLoader<String, Object> characterBatchLoader = new BatchLoader<String, Objec
@Override
public CompletionStage<List<Object>> load(List<String> keys) {
//
// we use supplyAsync() of values here for maximum parellisation
// we use supplyAsync() of values here for maximum parallelisation
//
return CompletableFuture.supplyAsync(() -> getCharacterDataViaBatchHTTPApi(keys));
}
Expand Down Expand Up @@ -179,7 +179,7 @@ at [https://github.com/graphql-java/java-dataloader](https://github.com/graphql-
## Data Loader only works with AsyncExecutionStrategy

The only execution that works with DataLoader is `graphql.execution.AsyncExecutionStrategy`. This is because this execution strategy knows
then the most optimal time to dispatch() your load calls is. It does this by deeply tracking how many fields are outstanding and whether they
when the most optimal time to dispatch() your load calls is. It does this by deeply tracking how many fields are outstanding and whether they
are list values and so on.

Other execution strategies such as `ExecutorServiceExecutionStrategy` can't do this and hence if the data loader code detects
Expand Down