Added the ability to have call context on batch loader calls #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbakerman
commented
Aug 19, 2018
| @SuppressWarnings("unused") | ||
| default CompletionStage<List<V>> load(List<K> keys, Object context) { | ||
| return load(keys); | ||
| } | ||
| } |
There was a problem hiding this comment.
Left in for API compat reasons. Ideally I would have just 1 method but it doesnt seem enough value to break people
Merged
bbakerman
commented
Aug 19, 2018
| @SuppressWarnings("unused") | ||
| default CompletionStage<List<V>> load(List<K> keys, Object context) { | ||
| return load(keys); | ||
| } |
There was a problem hiding this comment.
One thought I had was that we deprecated the old method and remove it later in a 3.0 but it seemed like too big leap (deprecate+remove later versus just have them implement 2 methods if they want context) for low value.
What are other peoples thoughts on this? @andimarek ? @kaqqao ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is stage 1 of the up coming 2.1 release.