Adding queued entries following cache clear #68
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using dynamoDB with this library.
DynamoDB will error if one batch request contains duplicate ids.
And ideally with the cache enabled this does not happen
When we insert an entity into the database we clear that id from the dataloader cache.
If that Id has already been requested but not dispatched clearing the cache means we can queue the same id again.
We have changed the clear methods to re-cache the queued requests.
Have not added any tests yet.
What other changes would like to see to get this in state that you would accept.
Maybe this behavior should be configurable on the dataloader what would you consider the default setting?
Thank you.