Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Contributing docs and refactor tox config #77

Merged
merged 10 commits into from Mar 14, 2020
Merged

Contributing docs and refactor tox config #77

merged 10 commits into from Mar 14, 2020

Conversation

KingDarBoja
Copy link
Contributor

  • Place dev and test packages inside setup python file.
  • Provide contributing docs for pip and conda developers.
  • Add Makefile

@coveralls
Copy link

coveralls commented Feb 26, 2020 •
edited

Coverage Status

Coverage remained the same at 93.548% when pulling fa8af4c on KingDarBoja:contributing-docs into d29cc6f on graphql-python:master.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.548% when pulling 30032f9 on KingDarBoja:contributing-docs into d29cc6f on graphql-python:master.

jkimbo
jkimbo requested changes Feb 26, 2020
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice thanks @KingDarBoja ! Couple of changes needed but otherwise this looks good

.travis.yml Outdated Show resolved Hide resolved
setup.py Outdated Show resolved Hide resolved
setup.py Show resolved Hide resolved
@jkimbo
Copy link
Member

jkimbo commented Mar 14, 2020

Thanks @KingDarBoja

@jkimbo jkimbo merged commit 88089b6 into graphql-python:master Mar 14, 2020
@KingDarBoja KingDarBoja deleted the contributing-docs branch March 14, 2020 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkimbo jkimbo jkimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@KingDarBoja @coveralls @jkimbo