Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

100% tests coverage! #107

Merged
merged 3 commits into from Jun 29, 2020
Merged

100% tests coverage! #107

merged 3 commits into from Jun 29, 2020

Conversation

leszekhanusz
Copy link
Collaborator

dsl: Fix select used multiple times on same field
local_schema: Fix correct return of errors in subscriptions

@leszekhanusz
100% coverage!
fb45bcb 
dsl: Fix select used multiple times on same field
local_schema: Fix correct return of errors in subscriptions
@coveralls
Copy link

coveralls commented Jun 28, 2020 •
edited

Coverage Status

Coverage increased (+0.8%) to 100.0% when pulling f5153cc on leszekhanusz:tests_complete_coverage into 5348b0a on graphql-python:master.

@leszekhanusz leszekhanusz self-assigned this Jun 28, 2020
@leszekhanusz leszekhanusz added type: bug An issue or pull request relating to a bug type: tests Adding missing or correcting existing tests labels Jun 28, 2020
@leszekhanusz leszekhanusz requested a review from Cito June 28, 2020 20:36
KingDarBoja
KingDarBoja approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@KingDarBoja KingDarBoja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good! 🚀

@KingDarBoja KingDarBoja added this to the Version 3.0 milestone Jun 29, 2020
Cito
Cito reviewed Jun 29, 2020
View reviewed changes
gql/dsl.py Outdated Show resolved Hide resolved
@leszekhanusz leszekhanusz merged commit ecb9e9b into graphql-python:master Jun 29, 2020
@leszekhanusz leszekhanusz deleted the tests_complete_coverage branch June 29, 2020 19:13
leszekhanusz added a commit to leszekhanusz/gql that referenced this pull request Jul 5, 2020
@leszekhanusz
100% tests coverage! (graphql-python#107)
bd83d33 
dsl: Fix select used multiple times on same field
local_schema: Fix correct return of errors in subscriptions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Cito left review comments

@KingDarBoja KingDarBoja KingDarBoja approved these changes

Assignees

@leszekhanusz leszekhanusz

Labels
type: bug An issue or pull request relating to a bug type: tests Adding missing or correcting existing tests
Projects
None yet
Milestone
Version 3.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@leszekhanusz @coveralls @Cito @KingDarBoja