Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync auto batching requests #436

Merged
merged 11 commits into from
Sep 13, 2023

Conversation

leszekhanusz
Copy link
Collaborator

Implementation of an automatic batching of requests for the sync transports.

See issue #430

@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (dfbcb59) 100.00% compared to head (02f249e) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #436   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           28        28           
  Lines         2497      2578   +81     
=========================================
+ Hits          2497      2578   +81     
Files Changed Coverage Δ
gql/client.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@leszekhanusz leszekhanusz mentioned this pull request Sep 9, 2023
@leszekhanusz leszekhanusz changed the title Implement sync auto batching requests Sync auto batching requests Sep 9, 2023
Copy link
Contributor

@itolosa itolosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a tiny change, the rest are question or suggestions. Also, I don't know if we should support the empty list as a valid argument in the requests parameter. If not, we should include an assert in the client

gql/client.py Show resolved Hide resolved
gql/client.py Show resolved Hide resolved
tests/test_requests_batch.py Show resolved Hide resolved
tests/test_requests_batch.py Show resolved Hide resolved
@leszekhanusz leszekhanusz merged commit ff3082b into graphql-python:master Sep 13, 2023
15 checks passed
@leszekhanusz leszekhanusz deleted the auto_batch_sync branch October 4, 2023 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants