Skip to content

Chore bump aiohttp to 3.11.2 #541

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

Chore bump aiohttp to 3.11.2 #541

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccd23ec
Use new aiohttp ws timeout
leszekhanusz Mar 12, 2025
7683e9e
We need at least aiohttp v3.11.2
leszekhanusz Mar 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 7 additions & 3 deletions gql/transport/common/adapters/aiohttp.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
from typing import Any, Dict, Literal, Mapping, Optional, Union

import aiohttp
from aiohttp import BasicAuth, Fingerprint, WSMsgType
from aiohttp import BasicAuth, ClientWSTimeout, Fingerprint, WSMsgType
from aiohttp.typedefs import LooseHeaders, StrOrURL
from multidict import CIMultiDictProxy

Expand Down Expand Up @@ -132,6 +132,11 @@ async def connect(self) -> None:

self.session = aiohttp.ClientSession(**client_session_args)

ws_timeout = ClientWSTimeout(
ws_receive=self.receive_timeout,
ws_close=self.websocket_close_timeout,
)

connect_args: Dict[str, Any] = {
"url": self.url,
"headers": self.headers,
Expand All @@ -142,8 +147,7 @@ async def connect(self) -> None:
"proxy": self.proxy,
"proxy_auth": self.proxy_auth,
"proxy_headers": self.proxy_headers,
"timeout": self.websocket_close_timeout,
"receive_timeout": self.receive_timeout,
"timeout": ws_timeout,
}

if self.subprotocols:
Expand Down
3 changes: 1 addition & 2 deletions setup.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,8 +38,7 @@
] + tests_requires

install_aiohttp_requires = [
"aiohttp>=3.8.0,<4;python_version<='3.11'",
"aiohttp>=3.9.0b0,<4;python_version>'3.11'",
"aiohttp>=3.11.2,<4",
]

install_requests_requires = [
Expand Down
Loading