Skip to content

Provide contributing docs, test suite fixes and return graphql errors #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Feb 27, 2020
Merged

Provide contributing docs, test suite fixes and return graphql errors #60

merged 9 commits into from
Feb 27, 2020

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Feb 23, 2020 •
edited
Loading

@KingDarBoja
chore: contributing docs and refactor dev packages
abec1f0 
- Place dev and test packages inside setup python file.
- Provide contributing docs for pip and conda developers.
- Add Makefile
@KingDarBoja KingDarBoja requested a review from Cito February 23, 2020 19:41
@KingDarBoja KingDarBoja changed the title chore: contributing docs and refactor dev packages Provide contributing docs, test suite fixes and return graphql errors Feb 24, 2020
@Cito
Copy link
Member

Cito commented Feb 26, 2020

Thank you @KingDarBoja - I had a quick glance and commented some issues. Note that the idea is to eventually merge gql-next in to gql and release it as the next major version.

Cito
Cito reviewed Feb 26, 2020
View reviewed changes
@KingDarBoja KingDarBoja requested a review from Cito February 27, 2020 03:30
@Cito Cito merged commit f779d32 into graphql-python:master Feb 27, 2020
@KingDarBoja KingDarBoja deleted the dev-tools-docs branch February 27, 2020 12:58
@KingDarBoja KingDarBoja added type: bug An issue or pull request relating to a bug type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation type: documentation An issue or pull request for improving or updating the documentation type: tests Adding missing or correcting existing tests labels Jun 14, 2020
@KingDarBoja KingDarBoja added this to the Version 2.0 milestone Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Cito Cito Awaiting requested review from Cito

Assignees
No one assigned
Labels
type: bug An issue or pull request relating to a bug type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation type: documentation An issue or pull request for improving or updating the documentation type: tests Adding missing or correcting existing tests
Projects
None yet
Milestone
Version 2.0
Development

Successfully merging this pull request may close these issues.

Allow 400 status code if result contain valid graphql error message
2 participants
@KingDarBoja @Cito