Skip to content

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented Feb 28, 2020

Aiming to improve test coverage and also provide little improvements to the gql package.

  • References Fix/Feature: Objects via params using DSL #24: Now the DSL support using mutation as stated on the referenced PR.
  • Add dsl mutation test.
  • Add http transport raise for status error test.
  • Add coveralls dev dependency and fix Travis CI to trigger it.
  • Add arg serializer test for GraphQLList and GraphQLEnum.
  • Remove get_ast_value from dsl.py as this is being done by get_arg_serializer.

@KingDarBoja KingDarBoja changed the title [WIP] Tests/coverage tests [WIP] Improve test coverage Feb 28, 2020
@KingDarBoja KingDarBoja changed the title [WIP] Improve test coverage Improve test coverage Feb 29, 2020
@KingDarBoja
Copy link
Contributor Author

@Cito This is ready for review :D

Copy link
Member

@Cito Cito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my two remarks, otherwise LGTM.

@Cito Cito merged commit 523bb72 into graphql-python:master Mar 4, 2020
@KingDarBoja KingDarBoja deleted the tests/coverage-tests branch March 4, 2020 21:29
@KingDarBoja KingDarBoja added this to the Version 2.0 milestone Jun 14, 2020
@KingDarBoja KingDarBoja added type: bug An issue or pull request relating to a bug type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation type: tests Adding missing or correcting existing tests labels Jun 14, 2020
@KingDarBoja KingDarBoja self-assigned this Jun 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug An issue or pull request relating to a bug type: chore Changes to the build process or auxiliary tools and libraries such as documentation generation type: tests Adding missing or correcting existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants