New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move testing endpoint to settings #1105
Move testing endpoint to settings #1105
Conversation
I'm not sure this should be a concern of library/tool developers. If a breaking change is documented well enough, it's okay imo. I'll try to review rest of it today. |
@ulgens Would you have time for a review? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems reasonable to have this target our v3 release when it happens. 👍
Any second opinions?
Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged? |
Hi @firaskafri, I see you merged main already, do you still need my assistance? It might take a few days due to my schedule |
Hello @syberen ! Yes it was a very tine conflict, but now seems that some of the tests are failing due to black formatting, would you please check when you have time? |
* Import testing endpoint from graphene settings * Add documentation for TESTING_ENDPOINT setting * Remove empty lines * Run formatter Co-authored-by: Firas K <3097061+firaskafri@users.noreply.github.com>
Fix #866
PLEASE NOTE: this will break testing for folks who have not pinned their version number, so maybe best to add to v3. I'm not sure which base branch to use for that, so please advise.
/graphql
)