Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move testing endpoint to settings #1105

Merged
merged 7 commits into from Sep 25, 2022

Conversation

syberen
Copy link
Contributor

@syberen syberen commented Jan 24, 2021

Fix #866

PLEASE NOTE: this will break testing for folks who have not pinned their version number, so maybe best to add to v3. I'm not sure which base branch to use for that, so please advise.

  • Make default testing endpoint consistent with graphql endpoint suggested in the installation documentation (/graphql)
  • Import testing endpoint from settings, provide default
  • Add test
  • Document default testing endpoint, and how to override in settings

@syberen syberen changed the base branch from main to v2 January 24, 2021 07:53
@syberen syberen changed the base branch from v2 to main January 24, 2021 07:53
@ulgens ulgens self-requested a review January 24, 2021 08:11
@ulgens
Copy link
Collaborator

ulgens commented Jan 24, 2021

this will break testing for folks who have not pinned their version number,

I'm not sure this should be a concern of library/tool developers. If a breaking change is documented well enough, it's okay imo. I'll try to review rest of it today.

@syberen
Copy link
Contributor Author

syberen commented May 5, 2021

@ulgens Would you have time for a review?

Copy link
Collaborator

@zbyte64 zbyte64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to have this target our v3 release when it happens. 👍

Any second opinions?

@firaskafri
Copy link
Collaborator

Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged?

@syberen
Copy link
Contributor Author

syberen commented Sep 24, 2022

Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged?

Hi @firaskafri, I see you merged main already, do you still need my assistance? It might take a few days due to my schedule

@firaskafri
Copy link
Collaborator

Hello @syberen , would you please resolve these conflicts so we can get it ready to be merged?

Hi @firaskafri, I see you merged main already, do you still need my assistance? It might take a few days due to my schedule

Hello @syberen ! Yes it was a very tine conflict, but now seems that some of the tests are failing due to black formatting, would you please check when you have time?

@firaskafri firaskafri merged commit bb03306 into graphql-python:main Sep 25, 2022
superlevure pushed a commit to loft-orbital/graphene-django that referenced this pull request Jul 19, 2023
* Import testing endpoint from graphene settings

* Add documentation for TESTING_ENDPOINT setting

* Remove empty lines

* Run formatter

Co-authored-by: Firas K <3097061+firaskafri@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

This will break/lead to not working tests if your endpoint is not '/graphql'
4 participants