-
Notifications
You must be signed in to change notification settings - Fork 766
Django permissions required at Nodes, Mutations and DjangoFilterConnectionField #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
2 similar comments
3 similar comments
Hi @syrusakbary, Django Filter 1.0.1 does not support Django 1.6 and Django 1.7 so update travis? or set Django Filter dependency to 0.11.0? I've done some changes to use Django permissions and I would like to have some feedback 👍 |
Hi!, any feedback? |
You should get this to pass the ci tests, I think you'll be more likely to get feedback from the core team if you do that |
Update jango-filter version
Thanks for your feedback @BossGrand I'm going to work to fix the issues and create a new pull request. |
After a lot of testing I've updated and pass all tests. Created auth mixins to require permissions at nodes and mutations also created AuthDjangoFilterConnectionField to create filters with permissions required. |
Hi @syrusakbary, I would like to have your feedback about these changes. I don't know if it fits in the project or if there is something to review and do it better. Thanks. |
bdc7189
to
f93251b
Compare
We definitely need some sort of permissions implementation. There have been a few different approaches proposed. I will try to aggregate the ideas and get discussion for which one we should implement. |
Hi @spockNinja I've done some changes to this solution to add more flexibility. Can I help upgrading this solution to version 2.0? |
Django permissions integration