Use maybe_queryset in DjangoFilterConnectionField #299
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In our projects we've found a need to inherit from DjangoFilterConnectionField in order to customize the queryset. When passing the queryset into "connection_resolver", an error was raised about "get_queryset" not existing. This is due to the assumption that the "base_manager" is always a manager. Using "maybe_queryset" resolves the issue.
Combine create and update into a single mutation. This can be disabled by returning None from `load_existing`.
|
Ah, I didn't mean for the second commit to end up here. I'll close this and open a new one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our projects we've found a need to inherit from
DjangoFilterConnectionField in order to customize the queryset. When
passing the queryset into "connection_resolver", an error was
raised about "get_queryset" not existing. This is due to the
assumption that the "base_manager" is always a manager. Using
"maybe_queryset" resolves the issue.
If there's a better way of doing any of this please let me know.