Skip to content

Conversation

BossGrand
Copy link
Member

@BossGrand BossGrand commented Nov 3, 2017

other queryset modifications being applied in resolvers.

the actual fix is really small.

In DjangoFilterConnectionField.merge_querysets default_queryset was overriding queryset.

if you look at DjangoConnectionField.merge_querysets you can see it was doing this merge correctly.

@classmethod
    def merge_querysets(cls, default_queryset, queryset):
        return queryset & default_queryset 

So this pr simply changes DjangoFilterConnectionField merge to match DjangoConnectionField merge. Along with a couple of tests

@BossGrand
Copy link
Member Author

Closing because I realized I accidentally rolled in a different pull request into this

@BossGrand BossGrand closed this Nov 3, 2017
@coveralls
Copy link

coveralls commented Nov 3, 2017

Coverage Status

Coverage increased (+0.01%) to 93.014% when pulling aa55a86 on BossGrand:fix/dj_filter_conn_field_merge_queries into 2600f0f on graphql-python:master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants