Skip to content

Conversation

mislavcimpersak
Copy link

@mislavcimpersak mislavcimpersak commented Jan 5, 2018

In both README.md and README.rst path to graphene's favicon is a dead end.

I've linked the favicon straight from the main graphene-python.org repo and now it displays properly.

Before:
screen shot 2018-01-05 at 10 56 21

After:
screen shot 2018-01-05 at 10 56 08

@coveralls
Copy link

coveralls commented Jan 5, 2018

Coverage Status

Coverage remained the same at 93.142% when pulling 72c49f2 on mislavcimpersak:master into b54e02c on graphql-python:master.

@spockNinja
Copy link
Contributor

@syrusakbary The link is indeed broken. However, you might want to fix it for http://graphene-python.org/ anyway, which would fix this link.

@mislavcimpersak
Copy link
Author

I'm closing this pull request since there isn't even a simple logo image in the graphene-python.org repo anymore so I can't fix it even there by just linking to the image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants