Fixes #400 #401
Merged
Fixes #400 #401
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After more digging than I expected (and planned), I'm 99% sure that the problem comes from `graphene_django`. I found a [comment](https://github.com/django/django/blob/16436f3751e9eec67a7b80b25c8e7d29a34be67e/django/db/models/fields/reverse_related.py#L4-L6) in Django's source that refers to an attribute named `remote_field`, instead of `rel`. It seamed to fix the problem for me without any other bugs (yet).
4 similar comments
|
@eyal0803 looks like this is failing with Django 1.8. Could you add a workaround? |
|
Good find though! |
Since I didn't know why the `rel` attribute wasn't there in the first place, maybe it's better to use the `remote_field` only if it's there and leave `rel` as a default (i.e else).
|
Thanks @eyal0803 ! @syrusakbary this looks good to merge now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After more digging than I expected (and planned), I'm 99% sure that the problem comes from
graphene_django. I checked (as much as I could) the source codes of: Django, Graphene, and Django Filter (and this one of course).I found a comment in Django's source that refers to an attribute named
remote_field, instead ofrel.It seamed to fix the problem for me without any other bugs (yet).