Skip to content

Conversation

ZuluPro
Copy link
Contributor

@ZuluPro ZuluPro commented May 6, 2018

Maybe it isn't the correct solution, but I wasn't able to have my ManyToManyField used.

Without this patch I receive: { "errors": [ { "message": "Cannot query field \"mymanyfield\" on type \"MyModelWithManyNode\".", "locations": [ { "line": 4, "column": 5 } ] } ] }

I made this patch from 2.0.0 as 2.0.1 doesn't work with my config.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 94.783% when pulling 346f93f on cloudspectatordevelopment:m2m into a480a39 on graphql-python:master.

1 similar comment
@coveralls
Copy link

coveralls commented May 6, 2018

Coverage Status

Coverage remained the same at 94.783% when pulling 346f93f on cloudspectatordevelopment:m2m into a480a39 on graphql-python:master.

@ZuluPro
Copy link
Contributor Author

ZuluPro commented May 20, 2018

@sciyoshi Any news ?

@sciyoshi
Copy link
Contributor

Hi @ZuluPro, this looks fine to me however I'm not a maintainer for this project so I'm unable to merge. You'll need to ask @syrusakbary or someone else with commit access to take a look.

@lgants
Copy link

lgants commented May 28, 2018

Can we get this merged?

@ZuluPro
Copy link
Contributor Author

ZuluPro commented Jun 5, 2018

@syrusakbary Any news

@syrusakbary
Copy link
Member

I like the PR and would love to merge, but we need tests testing the new changes, so we assure the issue is not replicated in future releases.

@mvanlonden
Copy link
Member

@ZuluPro mind adding some tests?

@firaskafri
Copy link
Collaborator

@ZuluPro interested to work on the tests?

@phalt
Copy link
Contributor

phalt commented May 3, 2019

I'd like to tidy up some of the PRs, so if we still want to work on this let me know or I will close this in 1 week.

@stale
Copy link

stale bot commented Jul 2, 2019

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jul 2, 2019
@stale stale bot closed this Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants