Skip to content

Conversation

zbyte64
Copy link
Collaborator

@zbyte64 zbyte64 commented Oct 19, 2018

Needs unit test but not entirely sure about patching settings.

Resolves #67

@coveralls
Copy link

Coverage Status

Coverage increased (+0.005%) to 94.523% when pulling 4f58783 on zbyte64:add_enum_choice into f76f38e on graphql-python:master.

@firaskafri
Copy link
Collaborator

@zbyte64 whats the alternative to enum to guarantee correct queries/mutations?

@zbyte64
Copy link
Collaborator Author

zbyte64 commented Mar 19, 2019

Way I see it there are 3 options:

  • Create one converter to rule them all. This is what we're doing right now, I don't think it will ever work.
  • Option to disable enum globally. More like a stopgap solution, should be avoided
  • Option to explicitly set the enum value. This is probably the right way to go. Check out Support formatting of enum choices #209

@zbyte64 zbyte64 closed this Mar 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants