Skip to content

Improve Error Message if error object is not type of DjangoObjectType #565

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from
Closed

Improve Error Message if error object is not type of DjangoObjectType #565

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
a8a2f00
improve error handling
bastiW Dec 29, 2018
60e6f4b
lint
bastiW Dec 29, 2018
23c727d
lint
bastiW Dec 29, 2018
9b53db4
lint
bastiW Dec 29, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 8 additions & 0 deletions graphene_django/settings.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,14 @@ def import_from_string(val, setting_name):
e.__class__.__name__,
e,
)
if "has no attribute 'name'" in str(e):
object_name = str(e).split("'")[1]
msg = "Could not import '%s' for Graphene setting '%s'. %s: %s must inherit from DjangoObjectType." % (
val,
setting_name,
e.__class__.__name__,
object_name,
)
raise ImportError(msg)


Expand Down