Make CSRF cookie and header names configuration based on django settings #585
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
Django allows the the CSRF cookie and header to be configured through the use of settings variables. graphene-django's implementation if GraphIQL does not respect these settings which causes a CSRF failure.
Fix:
This PR fixes the issue by reading the values from the django settings values and uses them in the graphiql template.
Repro:
Expected:
GraphIQL works as expected (request / response pass and scheme can be inspected)
Actual:
403 status' are returned due to a CSRF failure