Skip to content

Use field and exclude in docs instead deprecated attrs #740

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 7, 2019
Merged

Use field and exclude in docs instead deprecated attrs #740

merged 1 commit into from
Sep 7, 2019

Conversation

artofhuman
Copy link
Contributor

@artofhuman artofhuman commented Aug 8, 2019 •
edited
Loading

In #691 attrs only_fields and exclude_fields is deprecated in favor of fields and exclude and released

This PR fixed documentation which may confuse people.

jkimbo
jkimbo approved these changes Aug 8, 2019
View reviewed changes
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I thought I had got them all!

@mvanlonden mvanlonden merged commit ac79b38 into graphql-python:master Sep 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zbyte64 zbyte64 zbyte64 approved these changes

@jkimbo jkimbo jkimbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@artofhuman @zbyte64 @jkimbo @mvanlonden