Add list_length to connection returned by default_resolver in MongoengineConnectionField #72
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The recent changes to MongoengineConnectionField are great; however, one change was that the length of the queryset results is no longer applied to the connection object returned by the default_resolver.
This means that if someone were to implement a special Connection class such as below that provides a totalCount field (pretty common use case), the count() method has to be called a second time.
I'm not sure how much worse having to call count() a second time actually is (it might depend on various things), but I'd like opinions on whether it makes sense to just append the list_length to the connection so that we can avoid calling twice (as in this PR). Is there a reason not to append it?
Otherwise, would welcome suggestions on another way to avoid the second call.