Skip to content

Support 1.4 #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 31, 2020
Merged

Support 1.4 #21

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
81526b3
Update to support 1.4, make sure tests continue to pass
necaris Mar 23, 2020
07ef530
Update README.md
jaygorrell Mar 31, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ keywords = ["api", "graphql", "protocol", "rest", "relay", "graphene", "pydantic
python = "^3.6"
# To keep things simple, we only support newer versions of Graphene & Pydantic
graphene = ">=2.1.3,<3"
pydantic = ">=0.26,<=1.3"
pydantic = ">=0.26,<=1.4"

[tool.poetry.dev-dependencies]
pytest = "~4.6.4"
Expand Down
2 changes: 1 addition & 1 deletion tests/test_converters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ def test_unknown():
with pytest.raises(ConversionError) as exc:
_convert_field_from_spec("attr", (create_model("Model", size=int), None))
assert "Don't know how to convert" in exc.value.args[0]
if pydantic.version.VERSION < pydantic.version.StrictVersion("1.0"):
if pydantic.version.VERSION < "1.0":
assert "Field(attr type=Model default=None)" in exc.value.args[0]
else:
# this worked at least as of 1.1
Expand Down