Skip to content

Updates for 0.3.0 #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 37 commits into from
Jan 25, 2022
Merged

Updates for 0.3.0 #61

merged 37 commits into from
Jan 25, 2022

Conversation

necaris
Copy link
Collaborator

@necaris necaris commented May 8, 2021

Fixes for:

  • linting issues
  • type checking
  • Poetry (and other) dependencies
  • expanding test coverage to more recent Pythons, and dropping 3.6
  • support for more recent Pydantic, and dropping older versions

@necaris necaris changed the title Assorted fixes Updates for 0.3.0 Jan 25, 2022
This was referenced Jan 25, 2022
@necaris necaris requested a review from a team January 25, 2022 03:56
Copy link
Contributor

@dantheman39 dantheman39 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Rami!

@necaris necaris merged commit d4df6af into graphql-python:main Jan 25, 2022
@necaris necaris deleted the assorted-fixes branch January 25, 2022 16:36
@conglei
Copy link

conglei commented Feb 3, 2022

@necaris. Thanks for the timely response!!

My env is:
python 3.9
pydantic version: 1.8.2
graphene version: 2.1.9

For this env, the issues occurs all the time:

line 137, in convert_pydantic_field
    f = Field(resolver=get_attr_resolver(field.name), **field_kwargs)
TypeError: __init__() missing 1 required positional argument: 'type'

I think it is because for graphene.types.field.Field, it needs type..

@conglei
Copy link

conglei commented Feb 3, 2022

Ah.. I think I need to upgrade graphene version..

@conglei
Copy link

conglei commented Feb 3, 2022

I wonder if we can test the version of graphene here to make it backward compatible. Currently, upgrading the version of graphene may take tons of work..

If I comment out the line

    if "type_" not in field_kwargs and "type" in field_kwargs:
        field_kwargs["type_"] = field_kwargs.pop("type")

It will work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants