New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Would you consider a pull-request adding support for Peewee ORM? #289

Closed
coleifer opened this Issue Sep 14, 2016 · 14 comments

Comments

Projects
None yet
@coleifer

coleifer commented Sep 14, 2016

Hi, my name is Charles Leifer. I'm the author of Peewee, a lightweight Python ORM. It's been steadily growing in popularity in the last couple years and has over 3000 stars and 500+ forks. graphene is an impressive library and I am grateful to you for taking the time to write it and open-source it. I think it'd be great for the users of Peewee to be able to use your library, and if you did not want to write the bindings I would be happy to contribute some in a pull-request.

What do you think?

@syrusakbary

This comment has been minimized.

Show comment
Hide comment
@syrusakbary

syrusakbary Sep 15, 2016

Member

Hi Charles,

I'm absolutely open for having an integration between Peewee and Graphene, I think it will be super valuable for the developers!

Starting with the next version 1.0, Graphene integrations will be separated from the main codebase into external repos within the graphql-python community. (This is already happening for the Graphene Google App Engine integration)

Each of the repos will be maintained by different people that are specialized in the framework that are integrating with (I can't think of someone better than you for the graphene-peewee integration! 😉 )

We can follow the same process we did for graphene-gae: You can start a graphene-peewee repo in your profile and once is mature (tested and with a working example) we can move it into the graphql-python community :)

Or we can start directly creating a graphene-peewee repo in the graphql-python community and you will be the admin of this repo.

Just let me know what you prefer! :)

Member

syrusakbary commented Sep 15, 2016

Hi Charles,

I'm absolutely open for having an integration between Peewee and Graphene, I think it will be super valuable for the developers!

Starting with the next version 1.0, Graphene integrations will be separated from the main codebase into external repos within the graphql-python community. (This is already happening for the Graphene Google App Engine integration)

Each of the repos will be maintained by different people that are specialized in the framework that are integrating with (I can't think of someone better than you for the graphene-peewee integration! 😉 )

We can follow the same process we did for graphene-gae: You can start a graphene-peewee repo in your profile and once is mature (tested and with a working example) we can move it into the graphql-python community :)

Or we can start directly creating a graphene-peewee repo in the graphql-python community and you will be the admin of this repo.

Just let me know what you prefer! :)

@coleifer

This comment has been minimized.

Show comment
Hide comment
@coleifer

coleifer Sep 17, 2016

I'll take it on as a personal repo, and we can take it from there. Thanks for your encouragement and your interest!

coleifer commented Sep 17, 2016

I'll take it on as a personal repo, and we can take it from there. Thanks for your encouragement and your interest!

@coleifer coleifer closed this Sep 17, 2016

@syrusakbary

This comment has been minimized.

Show comment
Hide comment
@syrusakbary

syrusakbary Sep 17, 2016

Member

Great! :)
PS: I just added you the perms for maintain the graphene-peewee package in PyPI (if you want to use it!)

Member

syrusakbary commented Sep 17, 2016

Great! :)
PS: I just added you the perms for maintain the graphene-peewee package in PyPI (if you want to use it!)

@ParthGandhi

This comment has been minimized.

Show comment
Hide comment
@ParthGandhi

ParthGandhi Sep 19, 2016

@coleifer Awesome, look forward to it. I'd love to help if you need any.

ParthGandhi commented Sep 19, 2016

@coleifer Awesome, look forward to it. I'd love to help if you need any.

@joshdavey

This comment has been minimized.

Show comment
Hide comment
@joshdavey

joshdavey Oct 19, 2016

Hey guys, thanks so much for these two amazing libraries. Can't wait for them to work together officially. Is there anywhere I can follow the progress of graphene-peewee?

Thanks

joshdavey commented Oct 19, 2016

Hey guys, thanks so much for these two amazing libraries. Can't wait for them to work together officially. Is there anywhere I can follow the progress of graphene-peewee?

Thanks

@danigosa

This comment has been minimized.

Show comment
Hide comment
@danigosa

danigosa Dec 31, 2016

@coleifer we need to decide in our organization if we go for SQLAlchemy or Peewee (coming from Django ORM in older projects), could you open the work in progress so we can check how is it doing and possibly contribute to make it possible? Most devs in my team we prefer Peewee (congrats and thanx!) but GraphQL is one elevated requirement for the stack we are building.

danigosa commented Dec 31, 2016

@coleifer we need to decide in our organization if we go for SQLAlchemy or Peewee (coming from Django ORM in older projects), could you open the work in progress so we can check how is it doing and possibly contribute to make it possible? Most devs in my team we prefer Peewee (congrats and thanx!) but GraphQL is one elevated requirement for the stack we are building.

@coleifer

This comment has been minimized.

Show comment
Hide comment
@coleifer

coleifer Jan 3, 2017

Hey @danigosa -- between work and moving our house I don't believe I'll be able to work on this for at least a couple weeks. I hope you understand.

coleifer commented Jan 3, 2017

Hey @danigosa -- between work and moving our house I don't believe I'll be able to work on this for at least a couple weeks. I hope you understand.

@danigosa

This comment has been minimized.

Show comment
Hide comment
@danigosa

danigosa Jan 5, 2017

Don't even worry, we are facing other architecture layers? Anyway we are using peewee-async finally so no matter what in the times to come if you start this we'll contribute, for now we are not going to far in the frontend side to use graphql at its best so... Good luck with the move :)

danigosa commented Jan 5, 2017

Don't even worry, we are facing other architecture layers? Anyway we are using peewee-async finally so no matter what in the times to come if you start this we'll contribute, for now we are not going to far in the frontend side to use graphql at its best so... Good luck with the move :)

@axsauze

This comment has been minimized.

Show comment
Hide comment
@axsauze

axsauze Feb 28, 2017

Thank you very much for this contribution @coleifer! @danigosa I would definitely recommend Peewee, especially if you come from the Django ORM world

axsauze commented Feb 28, 2017

Thank you very much for this contribution @coleifer! @danigosa I would definitely recommend Peewee, especially if you come from the Django ORM world

@jontonsoup

This comment has been minimized.

Show comment
Hide comment
@jontonsoup

jontonsoup Apr 7, 2017

Is there a place where I can follow this? @coleifer

jontonsoup commented Apr 7, 2017

Is there a place where I can follow this? @coleifer

@Hendler

This comment has been minimized.

Show comment
Hide comment
@Hendler

Hendler Apr 28, 2017

Excited! Can we help out? Is there a place we can follow @coleifer ?

Hendler commented Apr 28, 2017

Excited! Can we help out? Is there a place we can follow @coleifer ?

@codejamninja

This comment has been minimized.

Show comment
Hide comment
@codejamninja

codejamninja Jun 26, 2017

What's the status of this? Are there any existing ways to use peewee with graphql?

codejamninja commented Jun 26, 2017

What's the status of this? Are there any existing ways to use peewee with graphql?

@alexpantyukhin

This comment has been minimized.

Show comment
Hide comment
@alexpantyukhin

alexpantyukhin Nov 22, 2017

It's interesting for me @coleifer @syrusakbary @danigosa . I can try to implement if it's not done yet and nobody already works with it..

alexpantyukhin commented Nov 22, 2017

It's interesting for me @coleifer @syrusakbary @danigosa . I can try to implement if it's not done yet and nobody already works with it..

@insolite

This comment has been minimized.

Show comment
Hide comment
@insolite

insolite Nov 27, 2017

If someone is interested I've done some implementation for peewee-async package here. It should not be much different from graphene-django integration which I mostly relied on at the design stage. Initially I was doing that for my own needs, but now I am trying to provide generic maintaining. So if someone will make use of it or want to contribute, I would be glad to help.

insolite commented Nov 27, 2017

If someone is interested I've done some implementation for peewee-async package here. It should not be much different from graphene-django integration which I mostly relied on at the design stage. Initially I was doing that for my own needs, but now I am trying to provide generic maintaining. So if someone will make use of it or want to contribute, I would be glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment