Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GenericIPAddressField support #70

Closed
kevin-abiera opened this issue Dec 12, 2015 · 2 comments
Closed

GenericIPAddressField support #70

kevin-abiera opened this issue Dec 12, 2015 · 2 comments

Comments

@kevin-abiera
Copy link
Contributor

It has been in Django since 1.4 and can be converted to String. I can submit a PR but I don't know how you want it. Can it be done the same way as UUIDField?
@syrusakbary
Copy link
Member

Yeah, any pull request will be more than welcome.
We only support Django 1.6+, so only adding models.GenericIPAddressField into convert_field_to_string should work ;)

@kevin-abiera
Copy link
Contributor Author

No need for checks then. Submitted #71, added a test in it too.

ronachong pushed a commit to ronachong/graphene that referenced this issue Nov 3, 2017
@syrusakbary
Merge pull request graphql-python#70 from patrickhsanders/fix-broken-…
94bab46 
…link

Fix broken link in cookbook example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@syrusakbary @kevin-abiera