Skip to content

Include extra data in Meta in _meta #1328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Include extra data in Meta in _meta #1328

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions graphene/types/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,7 @@ def __init_subclass_with_meta__(
return
_meta.name = name or cls.__name__
_meta.description = description or trim_docstring(cls.__doc__)
_meta.extra = _kwargs
Copy link
Member

@erikwrede erikwrede Aug 27, 2022 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the extra field should be an explicit class attribute of the BaseOptions class so that it can be properly documented. Otherwise users will be confused about the meaning or the purpose/won't find it at all. LMK what you think.

_meta.freeze()
cls._meta = _meta
super(BaseType, cls).__init_subclass_with_meta__()