Skip to content

Add meta attribute identifier for SQLAlchemyNode #146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 13, 2016
Merged

Add meta attribute identifier for SQLAlchemyNode #146

merged 5 commits into from
Apr 13, 2016

Conversation

karec
Copy link
Contributor

@karec karec commented Apr 13, 2016

Add ability to specify custom primary key column in SQLAlchemyNode through an identifier attribute in the meta class of it

@karec karec mentioned this pull request Apr 13, 2016
Closed
@karec
Copy link
Contributor Author

karec commented Apr 13, 2016

Reference to issue #145

@coveralls
Copy link

Coverage Status

Coverage increased (+0.06%) to 96.317% when pulling 492ffda on karec:master into 8497e0c on graphql-python:master.

@syrusakbary
Copy link
Member

Looks great! 👍

Merging (in few hours a new graphene version will be in pypi)

@syrusakbary syrusakbary merged commit 4d0d542 into graphql-python:master Apr 13, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@karec @coveralls @syrusakbary