Skip to content

relay Connection.node does not have to subclass Node/ObjectType #297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 19, 2016
Merged

relay Connection.node does not have to subclass Node/ObjectType #297

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8763424
relay Connection.node does not have to subclass Node/ObjectType
sjhewitt Aug 31, 2016
a77b279
re-add node class check
sjhewitt Sep 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions graphene/relay/connection.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,13 +6,14 @@

from graphql_relay import connection_from_list

from ..types import AbstractType, Boolean, Int, List, String
from ..types import (AbstractType, Boolean, Enum, Int, Interface, List, NonNull, Scalar, String,
Union)
from ..types.field import Field
from ..types.objecttype import ObjectType, ObjectTypeMeta
from ..types.options import Options
from ..utils.is_base_type import is_base_type
from ..utils.props import props
from .node import Node, is_node
from .node import is_node


class PageInfo(ObjectType):
Expand Down Expand Up @@ -57,7 +58,7 @@ def __new__(cls, name, bases, attrs):
options.local_fields = OrderedDict()

assert options.node, 'You have to provide a node in {}.Meta'.format(cls.__name__)
assert issubclass(options.node, (Node, ObjectType)), (
assert issubclass(options.node, (Scalar, Enum, ObjectType, Interface, Union, NonNull)), (
'Received incompatible node "{}" for Connection {}.'
).format(options.node, name)

Expand Down