Make default_backend type annotation more generous #265
Conversation
The code itself documents that only a GraphQLBackend is needed here, so relax the type annotation to match. Currently the annotation prevents callers setting any of the other types of backend as the default.
PeterJCLaw
changed the title
|
@Cito (randomly selected): this is my first contribution to this project, is there anything I need to do/can help with to help get this merged? (I couldn't see a contributing guide in the repo) |
|
@PeterJCLaw Just so you understand the situation. This repository is only for the legacy branch of graphql-core (v2) and not actively maintained any more. The current version of graphql-core (v3) is in the graphql-core-next repository. |
|
Oh, perhaps you could make that clearer in the README? |
|
@PeterJCLaw The type annotations were already added 2 years ago by @syrusakbary. It was only the py.typed flag was added in December. But you're right, renaming the repo and updating the README is long overdue. Will try to push this forward today. |
|
Ok, the repositories have been renamed now. GraphQL-core 2 is now graphql-core-legacy and GraphQL-core 3 is graphql-core. I also update the READMEs to better reflect this. |
|
@PeterJCLaw forgot to thank you for contributing! Added issue templates now to make the experience a bit better for newcomers. |
The code itself documents that only a
GraphQLBackendis needed here, so relax the type annotation to match. Currently the annotation prevents callers setting any of the other types of backend as the default.