Skip to content

Conversation

erikwrede
Copy link
Member

@erikwrede erikwrede commented Sep 13, 2025

This PR ports graphql/graphql-js#4078 to python to ease the adoption of the new oneOf directive freshly contained in the new spec release. As requested by strawberry issue strawberry-graphql/strawberry#3975

I left out the tests to src/utilities/__tests__/buildClientSchema-test.ts, as I couldn't find a matching file containing all relevant tests. Feel free to let me know if you desire any changes 😊

@erikwrede erikwrede requested a review from Cito as a code owner September 13, 2025 17:06
Copy link

codspeed-hq bot commented Sep 13, 2025

CodSpeed Performance Report

Merging #241 will not alter performance

Comparing erikwrede:feat/one-of-introspection (12abac7) with main (fa8f9b5)

Summary

✅ 14 untouched

@leszekhanusz
Copy link

leszekhanusz commented Sep 13, 2025

In graphql-python/gql#569, I added the same functionality to request isOneOf in the introspection query.

Downloading a schema with it from the console should be possible with gql-cli https://SERVER_URL/graphql --print-schema --schema-download input_object_one_of:true > schema.graphql

Now, does anyone knows any public backend which allows introspection and has isOneOf in its schema to test this?

@Cito
Copy link
Member

Cito commented Sep 14, 2025

Thank you @erikwrede. Will merge next week, fix linting and add the missing tests, you don't need to bother.

Sorry for lagging behind.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants