-
-
Notifications
You must be signed in to change notification settings - Fork 133
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement __hash__ for GraphQLError #35
Conversation
0af6d94
to
dac9396
Compare
Thank your for providing this PR. Hashing only But I think the best and most performant solution is to simply use the default hash method for exceptions, based on the id of the instance. GraphQLError lost that default hash capability when it got a custom |
Your reasoning makes a lot of sense to me. I pushed a commit — is this what you had in mind? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thank you.
Fixes #34
This seemed like the most minimal implementation that might be safe, but it's definitely possible there's some context I'm missing. I also claim no mastery of python!