Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge sanic-graphql #38

Merged
merged 3 commits into from Jun 6, 2020

Conversation

KingDarBoja
Copy link
Contributor

@KingDarBoja KingDarBoja commented May 7, 2020

References #34, this PR merges sanic-graphql library into graphql-server-core.

To install the integration with sanic, run the below command on your terminal.
pip install graphql-server-core[sanic]

NOTE The only main issue so far is dealing with the asyncio executor tests.

@KingDarBoja KingDarBoja added the type: feature A new feature label May 7, 2020
@KingDarBoja KingDarBoja requested a review from jkimbo May 7, 2020 04:50
@KingDarBoja KingDarBoja self-assigned this May 7, 2020
Copy link
Member

@jkimbo jkimbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good @KingDarBoja . Whats left to do?

tests/sanic/app.py Outdated Show resolved Hide resolved
graphql_server/sanic/render_graphiql.py Show resolved Hide resolved
@KingDarBoja KingDarBoja marked this pull request as ready for review May 10, 2020 21:46
@KingDarBoja KingDarBoja requested a review from jkimbo May 10, 2020 21:49
This was referenced May 16, 2020
@KingDarBoja KingDarBoja requested a review from Cito June 2, 2020 23:07
@KingDarBoja KingDarBoja merged commit 35ed87d into graphql-python:master Jun 6, 2020
@KingDarBoja KingDarBoja deleted the merge-sanic-graphql branch June 6, 2020 16:40
@KingDarBoja KingDarBoja added this to the GraphQL-Server (V3) milestone Jul 12, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature A new feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants