graphql_query_derive: support deriving for input variables as well #109
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mathstuf
force-pushed
the
derive-for-inputs
branch
from
5b8063c to
e05690d
Compare
tomhoule
approved these changes
Sep 15, 2018
| .split(',') | ||
| .map(|s| s.trim()) | ||
| .map(|s| Ident::new(s, Span::call_site())), | ||
| ); |
There was a problem hiding this comment.
So we derive the same traits as for the response at the moment, that seems like a good start. I think we might want to enable users to choose different derives for variables and ResponseData (since the use cases are different) in the future, but it's a good start. Great!
|
I'll happily merge after the branch is rebased :) |
|
I'll also document it in the changelog. |
This just hijacks the `reponse_derives` attribute right now since it controls derives for generated data structures and `Variables` shares much of that. Fixes graphql-rust#103.
mathstuf
force-pushed
the
derive-for-inputs
branch
from
e05690d to
e06150f
Compare
|
Rebased and changelog entry added. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just hijacks the
reponse_derivesattribute right now since itcontrols derives for generated data structures and
Variablessharesmuch of that.
Fixes #103.
Should
response_derivesbe renamed toextra_derivessince it now applies to every generated type?