Skip to content

Specify graphql_client_codegen version #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2018

Conversation

h-michael
Copy link
Member

  • specify dependency version

@tomhoule
Copy link
Member

It makes sense indeed. I don't have enough experience with publishing multi-crate projects, but I think we should push graphql_client_codegen to crates.io at the same time as the next release of graphql-client (hopefully in the next 10 days, I'm going to give a small presentation to a local meetup about the library and it would be nice to have a new release - there are a lot of awesome unreleased features now). Do you have more experience/ideas on that topic?

@tomhoule tomhoule merged commit a82359b into graphql-rust:master Sep 16, 2018
@h-michael
Copy link
Member Author

@tomhoule
I'm going to implement code generation with cli!

@h-michael h-michael deleted the specify-version branch September 17, 2018 04:19
@h-michael
Copy link
Member Author

@tomhoule
Now we have the same version of each crate,
but what if we make breaking changes only on dependent crate?

@tomhoule
Copy link
Member

I'll try to read up on this - but I think it's maybe good to keep all crates at the same version because users should only import graphql_client and not the others.

@h-michael
Copy link
Member Author

I'll try to read up on this

Sorry, what's this you said ?

@tomhoule
Copy link
Member

Maybe there are blog posts or articles with good solutions to this problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants