Skip to content

Add env_logger to cli #193

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Conversation

h-michael
Copy link
Member

I want to debug graphql_client_codegen via cli.

@tomhoule
Copy link
Member

Sorry I'm not too available for reviews at the moment. I think most of the diff in this PR is caused by rustfmt on nightly instead of stable (they give slightly different formatting - the one on stable is better in my experience). I'll try to be back for a full review asap!

@h-michael
Copy link
Member Author

@tomhoule Thanks, if you have a time to review, you had better to review #194 at first.
That pr is only execute rust-fmt and fix clippy.
And this pr rebase #194.

@h-michael h-michael force-pushed the logging branch 4 times, most recently from eee59af to 36dd01a Compare December 13, 2018 00:18
@tomhoule
Copy link
Member

Thanks! Merged as part of #197

And sorry for the very long review delay!

@tomhoule tomhoule closed this Dec 18, 2018
@h-michael h-michael deleted the logging branch December 19, 2018 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants