Skip to content

Migrate to 2018 edition and away from skeptic #236

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 15, 2019
Merged

Migrate to 2018 edition and away from skeptic #236

merged 7 commits into from
May 15, 2019

Conversation

tomhoule
Copy link
Member

TODO:

  • Document how to require serde now.

@tomhoule tomhoule force-pushed the no-skeptic branch 2 times, most recently from 9f23697 to 058234c Compare April 12, 2019 19:19
@fnune
Copy link

fnune commented Apr 20, 2019

Is automatically resolving use statements a new feature in Rust?

@tomhoule
Copy link
Member Author

it's part of the 2018 edition: https://doc.rust-lang.org/nightly/edition-guide/rust-2018/module-system/path-clarity.html

@fnune
Copy link

fnune commented Apr 20, 2019

Awesome!

Also removes the dependency on skeptic.

TODO:

- Document how to require serde now.
@tomhoule tomhoule force-pushed the no-skeptic branch 2 times, most recently from 49bbcca to b0d677a Compare May 8, 2019 06:15
@tomhoule tomhoule changed the title WIP: Remove most uses of extern crate Migrate to 2018 edition and away from skeptic May 8, 2019
@tomhoule tomhoule merged commit c9f3045 into master May 15, 2019
@tomhoule tomhoule deleted the no-skeptic branch May 15, 2019 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants