-
Notifications
You must be signed in to change notification settings - Fork 163
Option for externally defined enums #359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,83 @@ | ||
use graphql_client::*; | ||
use serde::Deserialize; | ||
|
||
/* | ||
* Enums under test | ||
* | ||
* They rename the fields to use SCREAMING_SNAKE_CASE for deserialization, as it is the standard for GraphQL enums. | ||
*/ | ||
#[derive(Deserialize, Debug, PartialEq)] | ||
#[serde(rename_all = "SCREAMING_SNAKE_CASE")] | ||
pub enum Direction { | ||
North, | ||
East, | ||
South, | ||
West, | ||
} | ||
|
||
#[derive(Deserialize, Debug, PartialEq)] | ||
#[serde(rename_all = "SCREAMING_SNAKE_CASE")] | ||
pub enum DistanceUnit { | ||
Meter, | ||
Feet, | ||
SomethingElseWithMultipleWords, | ||
} | ||
|
||
/* Queries */ | ||
|
||
// Minimal setup using extern enum. | ||
#[derive(GraphQLQuery)] | ||
#[graphql( | ||
schema_path = "tests/extern_enums/schema.graphql", | ||
query_path = "tests/extern_enums/single_extern_enum_query.graphql", | ||
extern_enums("DistanceUnit") | ||
)] | ||
pub struct SingleExternEnumQuery; | ||
|
||
// Tests using multiple externally defined enums. Also covers mixing with derived traits and with nullable GraphQL enum values. | ||
#[derive(GraphQLQuery)] | ||
#[graphql( | ||
schema_path = "tests/extern_enums/schema.graphql", | ||
query_path = "tests/extern_enums/multiple_extern_enums_query.graphql", | ||
response_derives = "Debug, PartialEq", | ||
extern_enums("Direction", "DistanceUnit") | ||
)] | ||
pub struct MultipleExternEnumsQuery; | ||
|
||
/* Tests */ | ||
|
||
#[test] | ||
fn single_extern_enum() { | ||
const RESPONSE: &str = include_str!("extern_enums/single_extern_enum_response.json"); | ||
|
||
println!("{:?}", RESPONSE); | ||
let response_data: single_extern_enum_query::ResponseData = | ||
serde_json::from_str(RESPONSE).unwrap(); | ||
|
||
println!("{:?}", response_data.unit); | ||
|
||
let expected = single_extern_enum_query::ResponseData { | ||
unit: DistanceUnit::Meter, | ||
}; | ||
|
||
assert_eq!(response_data.unit, expected.unit); | ||
} | ||
|
||
#[test] | ||
fn multiple_extern_enums() { | ||
const RESPONSE: &str = include_str!("extern_enums/multiple_extern_enums_response.json"); | ||
|
||
println!("{:?}", RESPONSE); | ||
let response_data: multiple_extern_enums_query::ResponseData = | ||
serde_json::from_str(RESPONSE).unwrap(); | ||
|
||
println!("{:?}", response_data); | ||
|
||
let expected = multiple_extern_enums_query::ResponseData { | ||
distance: 100, | ||
direction: Some(Direction::North), | ||
unit: DistanceUnit::SomethingElseWithMultipleWords, | ||
}; | ||
|
||
assert_eq!(response_data, expected); | ||
} |
5 changes: 5 additions & 0 deletions
5
graphql_client/tests/extern_enums/multiple_extern_enums_query.graphql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
query MultipleExternEnumsQuery { | ||
distance | ||
unit | ||
direction | ||
} |
5 changes: 5 additions & 0 deletions
5
graphql_client/tests/extern_enums/multiple_extern_enums_response.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
{ | ||
"distance": 100, | ||
"unit": "SOMETHING_ELSE_WITH_MULTIPLE_WORDS", | ||
"direction": "NORTH" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,22 @@ | ||
schema { | ||
query: ExternEnumQueryRoot | ||
} | ||
|
||
enum Direction { | ||
NORTH | ||
EAST | ||
SOUTH | ||
WEST | ||
} | ||
|
||
enum DistanceUnit { | ||
METER | ||
FEET | ||
SOMETHING_ELSE_WITH_MULTIPLE_WORDS | ||
} | ||
|
||
type ExternEnumQueryRoot { | ||
distance: Int! | ||
unit: DistanceUnit! | ||
direction: Direction | ||
} |
3 changes: 3 additions & 0 deletions
3
graphql_client/tests/extern_enums/single_extern_enum_query.graphql
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
query SingleExternEnumQuery { | ||
unit | ||
} |
3 changes: 3 additions & 0 deletions
3
graphql_client/tests/extern_enums/single_extern_enum_response.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
{ | ||
"unit": "METER" | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I assume this just works because the generated modules already
use super::*
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, it very much relies on that. It's simple and it works. :) Unless you think
use super::*
might be removed in the future, I don't really see this as a problem. But happy to look into alternatives if you think there could be a cleaner solution.