Skip to content

Fix juniper_codegen_tests #1007

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 20, 2021
Merged

Fix juniper_codegen_tests #1007

merged 3 commits into from
Dec 20, 2021

Conversation

ilslv
Copy link
Member

@ilslv ilslv commented Dec 20, 2021 •
edited by tyranron
Loading

Synopsis

For now juniper_codegen_tests fails on latest nightly

Solution

Fix those assertions.

Checklist

  • Created PR:
    • In draft mode
    • Name contains Draft: prefix
    • Name contains issue reference
    • Has assignee
  • Documentation is updated (if required)
  • Tests are updated (if required)
  • Changes conform code style
  • CHANGELOG entry is added (if required)
  • FCM (final commit message) is posted
    • and approved
  • Review is completed and changes are approved
  • Before merge:
    • Milestone is set
    • PR's name and description are correct and up-to-date
    • Draft: prefix is removed
    • All temporary labels are removed

@ilslv ilslv self-assigned this Dec 20, 2021
@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Dec 20, 2021
@ilslv
Copy link
Member Author

ilslv commented Dec 20, 2021

FCM

Fix `juniper_codegen_tests` assertions (#1007)

@ilslv ilslv changed the title Draft: Fix juniper_codegen_tests Fix juniper_codegen_tests Dec 20, 2021
@ilslv ilslv marked this pull request as ready for review December 20, 2021 12:19
@tyranron tyranron removed the enhancement Improvement of existing features or bugfix label Dec 20, 2021
@ilslv ilslv requested a review from tyranron December 20, 2021 12:50
@ilslv ilslv added the enhancement Improvement of existing features or bugfix label Dec 20, 2021
@tyranron tyranron merged commit f504da6 into master Dec 20, 2021
@tyranron tyranron deleted the fix-codegen-tests branch December 20, 2021 12:50
@ilslv ilslv removed the enhancement Improvement of existing features or bugfix label Dec 20, 2021
@tyranron tyranron added this to the 0.16.0 milestone Apr 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tyranron tyranron tyranron approved these changes

Assignees

@ilslv ilslv

Labels

None yet

Projects

None yet

Milestone

0.16.0

Development

Successfully merging this pull request may close these issues.

2 participants

@ilslv @tyranron