Fix typos and add GitHub Action job for /book #1121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@tyranron Should we fix all the typo errors in the whole repo before adding the CI job? |
|
@kianmeng let's try and see. I'm not strictly opposed to this. |
kianmeng
force-pushed
the
fix-typos-for-book
branch
2 times, most recently
from
899acab to
48ff884
Compare
|
@tyranron Sorry for the delay, I've added the GHA, but can't test and validate it from my end. |
kianmeng
changed the title
kianmeng
force-pushed
the
fix-typos-for-book
branch
from
48ff884 to
f1a87c3
Compare
Found via `codespell book/ -L crate`
kianmeng
force-pushed
the
fix-typos-for-book
branch
from
f1a87c3 to
a9c03b0
Compare
|
@tyranron (up) |
|
@tyranron Can this be merged? I don't see which changes are outstanding. |
|
🥳 🥳 🥳 🥳 🥳 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found via
codespell book/ -L crate