feat: introduce proper vscode completion kinds #1488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this re-uses vscode's own CompletionItemKind to introduce completion kinds at the LSP interface level. these will make different icons appear for different types on completion. then, monaco has slightly different kinds that we will map to from these in a later PR
acao
force-pushed
the
feat/completion-item-kinds
branch
from
e964b0b
to
93b215d
Compare
acao
force-pushed
the
feat/completion-item-kinds
branch
from
93b215d
to
5000900
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this re-uses vscode's own CompletionItemKind to introduce completion kinds at the LSP interface level. these will make different icons appear for different types on completion. currently kind values are not returned, so it's up to the user to specify them.
also, introduce a const for RuleKinds lookup that will be used by monaco. using these, monaco has slightly different kinds that we will configure in a simple lookup object in a later PR